Support exporting jar#271
Merged
Merged
Conversation
Update function with no params and add plugin.xml
|
|
jdneo
requested changes
Jun 23, 2020
jdneo
requested changes
Jun 24, 2020
jdneo
reviewed
Jun 24, 2020
jdneo
reviewed
Jun 24, 2020
jdneo
requested changes
Jun 24, 2020
Support export jar feature.
testforstephen
requested changes
Jul 16, 2020
jdneo
requested changes
Jul 17, 2020
Member
jdneo
left a comment
jdneo
left a comment
There was a problem hiding this comment.
As @testforstephen has mentioned, there are several unnecessary files/code in this PR. Please remove them first. Also, remember add license header when you adding a new file.
jdneo
reviewed
Jul 17, 2020
|
Hi, this seams great. |
Contributor
Author
We will put an |
jdneo
requested changes
Jul 27, 2020
| case ExportSteps.ResolveProject: { | ||
| projectFolder = await resolveProject(pickSteps, node); | ||
| projectUri = Uri.parse(projectFolder); | ||
| rootNodes = await Jdtls.getProjects(projectUri.toString()); |
Member
There was a problem hiding this comment.
Is rootNode here meaning a project node?
Contributor
Author
There was a problem hiding this comment.
Not exactly. For maven project as an example, rootNodes is an Array which includes all the modules defined in pom.xml.
Member
There was a problem hiding this comment.
submodules are still projects. rootNode is misleading here, what is root? is it workspace root? And what is node? we don't have tree structure here
jdneo
reviewed
Jul 28, 2020
jdneo
reviewed
Jul 28, 2020
jdneo
reviewed
Jul 29, 2020
java.view.package.exportJar -> java.view.package.generateJar
jdneo
requested changes
Jul 29, 2020
jdneo
requested changes
Jul 30, 2020
jdneo
reviewed
Jul 30, 2020
| }, (progress, token) => { | ||
| return new Promise<IJarQuickPickItem[]>(async (resolve, reject) => { | ||
| token.onCancellationRequested(() => { | ||
| return reject(); |
jdneo
reviewed
Jul 30, 2020
jdneo
reviewed
Jul 30, 2020
| try { | ||
| step = await stepMap.get(step).execute(stepMetadata); | ||
| } catch (err) { | ||
| if (err === undefined) { |
Member
There was a problem hiding this comment.
return err ? reject(${err}) : reject()
| } | ||
| const disposables: Disposable[] = []; | ||
| let pickBox: QuickPick<IJarQuickPickItem>; | ||
| const result = await new Promise<boolean>(async (resolve, reject) => { |
1.Fix disposables bugs 2.move stepMap to grobal
jdneo
reviewed
Jul 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 'getMainMethod' command in jdtls.ext, which will return all the existing main methods of the workspace.